Fix Config.InsecureSkipTimeVerify not being respected #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaukas
approved these changes
Jul 16, 2024
|
If no more edits are going to be made on this pull request, I will be merging it by the end of day. Let me know before that if you want me to hold @adotkhan. |
|
Thanks for the quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where server cert expiry is verified even though
Config.InsecureSkipTimeVerifyis set to true.It seems that this issue has come about after the uTLS sync with Go 1.21, where the upstream crypto/tls has moved the code to verify server cert expiry above the InsecureSkipVerify check.